Showing 36 of 36 total issues
Assignment Branch Condition size for get_revisions_from_lines is too high. [37.82/15] Open
def get_revisions_from_lines(lines, search = nil, branch = nil, limit = nil)
check_type __callee__, 'lines', lines.is_a?(Array)
lines.each_with_index do |line, index|
check_type __callee__, format('lines[%<index>d]', index: index), line.is_a?(String)
end
- Read upRead up
- Exclude checks
This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric
Method has too many lines. [25/10] Open
def get_revisions_from_lines(lines, search = nil, branch = nil, limit = nil)
check_type __callee__, 'lines', lines.is_a?(Array)
lines.each_with_index do |line, index|
check_type __callee__, format('lines[%<index>d]', index: index), line.is_a?(String)
end
- Read upRead up
- Exclude checks
This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.
Assignment Branch Condition size for issue_links is too high. [26.31/15] Open
def issue_links
return unless context.current[:info]
case context.current[:type]
when :commit
return unless context.current[:info][:commit]
- Read upRead up
- Exclude checks
This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric
Class Output
has 22 methods (exceeds 20 allowed). Consider refactoring. Open
class Output < Mustache
@@template_format = 'txt'
self.template_path = format('%<dir>s/output', dir: File.dirname(__FILE__))
self.template_file = format('%<dir>s/output/output_%<format>s.mustache', dir: File.dirname(__FILE__), format: @@template_format)
Assignment Branch Condition size for release_header is too high. [20.1/15] Open
def release_header
case context.current[:release]
when :next
t('committed.output.next_release')
when :previous
- Read upRead up
- Exclude checks
This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric
Assignment Branch Condition size for item_lines is too high. [19.52/15] Open
def item_lines
return unless context.current[:info]
case context.current[:type]
when :commit
message = context.current[:info][:commit][:message]
- Read upRead up
- Exclude checks
This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric
Method has too many lines. [14/10] Open
def register_deployment_status(user, repo, id, state)
validate_user_and_repo(user, repo, __callee__)
validate('id', id, Integer, __callee__)
valid_states = %w[pending success error failure]
- Read upRead up
- Exclude checks
This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.
Method has too many lines. [12/10] Open
def release_header
case context.current[:release]
when :next
t('committed.output.next_release')
when :previous
- Read upRead up
- Exclude checks
This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.
Assignment Branch Condition size for add_dates_to_revisions is too high. [17.58/15] Open
def add_dates_to_revisions(revisions, github, git_user = nil, git_repo = nil)
check_type __callee__, 'revisions', revisions.is_a?(Hash)
check_type __callee__, 'github', github.is_a?(Capistrano::Committed::GithubApi)
git_user = check_git_user(git_user)
git_repo = check_git_repo(git_repo)
- Read upRead up
- Exclude checks
This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric
Assignment Branch Condition size for item_title is too high. [16.28/15] Open
def item_title
return unless context.current[:info]
case context.current[:type]
when :commit
t('committed.output.commit_sha',
- Read upRead up
- Exclude checks
This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric
Assignment Branch Condition size for item_created_by is too high. [16.28/15] Open
def item_created_by
return unless context.current[:info]
case context.current[:type]
when :commit
format_created_by('committed.output.committed_by', context.current[:info][:committer])
- Read upRead up
- Exclude checks
This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric
Method has too many lines. [11/10] Open
def register_deployment(user, repo, stage, branch = 'master')
validate_user_and_repo(user, repo, __callee__)
validate('stage', stage, String, __callee__)
validate('branch', branch, String, __callee__)
- Read upRead up
- Exclude checks
This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.
Method has too many lines. [11/10] Open
def get_pull_request(user, repo, number)
validate_user_and_repo(user, repo, __callee__)
validate('number', number, Integer, __callee__)
api_call do
- Read upRead up
- Exclude checks
This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.
Assignment Branch Condition size for item_link is too high. [15.3/15] Open
def item_link
return unless context.current[:info]
case context.current[:type]
when :commit, :pull_request
return unless context.current[:info][:html_url]
- Read upRead up
- Exclude checks
This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric
Assignment Branch Condition size for commits is too high. [15.3/15] Open
def commits
return unless context.current[:type] == :pull_request
return unless context.current[:commits]
return if context.current[:commits].empty?
context.current[:commits].flatten
- Read upRead up
- Exclude checks
This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric
Method get_revisions_from_lines
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def get_revisions_from_lines(lines, search = nil, branch = nil, limit = nil)
check_type __callee__, 'lines', lines.is_a?(Array)
lines.each_with_index do |line, index|
check_type __callee__, format('lines[%<index>d]', index: index), line.is_a?(String)
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method issue_links
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def issue_links
return unless context.current[:info]
case context.current[:type]
when :commit
return unless context.current[:info][:commit]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add_dates_to_revisions
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def add_dates_to_revisions(revisions, github, git_user = nil, git_repo = nil)
check_type __callee__, 'revisions', revisions.is_a?(Hash)
check_type __callee__, 'github', github.is_a?(Capistrano::Committed::GithubApi)
git_user = check_git_user(git_user)
git_repo = check_git_repo(git_repo)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method item_link
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def item_link
return unless context.current[:info]
case context.current[:type]
when :commit, :pull_request
return unless context.current[:info][:html_url]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Missing magic comment # frozen_string_literal: true
. Open
require 'github_api'
- Read upRead up
- Exclude checks
This cop is designed to help upgrade to Ruby 3.0. It will add the
comment # frozen_string_literal: true
to the top of files to
enable frozen string literals. Frozen string literals may be default
in Ruby 3.0. The comment will be added below a shebang and encoding
comment. The frozen string literal comment is only valid in Ruby 2.3+.
Example: EnforcedStyle: when_needed (default)
# The `when_needed` style will add the frozen string literal comment
# to files only when the `TargetRubyVersion` is set to 2.3+.
# bad
module Foo
# ...
end
# good
# frozen_string_literal: true
module Foo
# ...
end
Example: EnforcedStyle: always
# The `always` style will always add the frozen string literal comment
# to a file, regardless of the Ruby version or if `freeze` or `<<` are
# called on a string literal.
# bad
module Bar
# ...
end
# good
# frozen_string_literal: true
module Bar
# ...
end
Example: EnforcedStyle: never
# The `never` will enforce that the frozen string literal comment does
# not exist in a file.
# bad
# frozen_string_literal: true
module Baz
# ...
end
# good
module Baz
# ...
end