Showing 18 of 18 total issues
Function namespaced
has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring. Open
function namespaced(namespaceId) {
if (namespaceId === "clusterphone") {
if (internalNameGuard === 0) {
throw new Error("The 'clusterphone' namespace name is private. Sorry.");
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function namespaced
has 159 lines of code (exceeds 25 allowed). Consider refactoring. Open
function namespaced(namespaceId) {
if (namespaceId === "clusterphone") {
if (internalNameGuard === 0) {
throw new Error("The 'clusterphone' namespace name is private. Sorry.");
}
Similar blocks of code found in 2 locations. Consider refactoring. Open
setTimeout(function() {
var end = Date.now();
var throughput = bytes / (end - start) / 1024 / 1024;
running = false;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 84.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
setTimeout(function() {
var end = Date.now();
var throughput = bytes / (end - start) / 1024 / 1024;
running = false;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 84.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function fireMessageHandler
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
function fireMessageHandler(nsName, seq, handler, cmd, payload, fd) {
/* jshint validthis:true */
var args = [payload, fd];
if (this !== process) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File clusterphone.js
has 253 lines of code (exceeds 250 allowed). Consider refactoring. Open
"use strict";
var cluster = require("cluster"),
Promise = require("bluebird"),
semver = require("semver"),
Function fireMessageHandler
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
function fireMessageHandler(nsName, seq, handler, cmd, payload, fd) {
/* jshint validthis:true */
var args = [payload, fd];
if (this !== process) {
Function constructMessageApi
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
function constructMessageApi(namespace, cmd, destName, seq) {
var api = {},
valid = true,
timeout = module.exports.ackTimeout,
resolve,
Function sendTo
has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
var sendTo = function(worker, cmd, payload, fd, forceSendFD) {
if (!worker) {
throw new TypeError("Worker must be specified");
}
Function constructMessageApi
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
function constructMessageApi(namespace, cmd, destName, seq) {
var api = {},
valid = true,
timeout = module.exports.ackTimeout,
resolve,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function handlerPromise
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
var handlerPromise = new Promise(function(resolve, reject) {
var ackSent = false,
result;
var acknowledge = function(reply) {
Function sendToMaster
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
var sendToMaster = function(cmd, payload, fd) {
var seq = seqCounter++,
api = constructMessageApi(namespace, cmd, "master", seq);
cmd = cmd ? String(cmd) : cmd;
Function messageBus
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports = function messageBus(message, fd) {
/* jshint validthis:true */
/* istanbul ignore if */
if (!message || !message.__clusterphone) {
Function fireMessageHandler
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
function fireMessageHandler(nsName, seq, handler, cmd, payload, fd) {
Function sendTo
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
var sendTo = function(worker, cmd, payload, fd, forceSendFD) {
Function handleAck
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
function handleAck(ackNum, message, namespace) {
/* jshint validthis:true */
debug("Handling ack for seq " + ackNum);
var pending = namespace.getPending.call(this, ackNum);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function messageBus
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
module.exports = function messageBus(message, fd) {
/* jshint validthis:true */
/* istanbul ignore if */
if (!message || !message.__clusterphone) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this function. Open
return sendAck.call(this, nsName, seq, null, "Unhandled message type");