Showing 14 of 14 total issues
Function getFeed
has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring. Open
var getFeed = function(params, auth, query, cb) {
var visibility = "public";
var projection = "values";
var options = {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function Row
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
var Row = function(data) {
Object.keys(data).forEach(function(key) {
var val;
val = data[key];
if(key.substring(0, 4) === "gsx:") {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File spreadsheets.js
has 260 lines of code (exceeds 250 allowed). Consider refactoring. Open
"use strict";
var axios = require("axios");
var statuses = require("statuses");
var querystring = require("querystring");
Function getFeed
has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
var getFeed = function(params, auth, query, cb) {
var visibility = "public";
var projection = "values";
var options = {
Function rows
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
Spreadsheets.rows = function(opts, cb) {
if(!opts) {
throw new Error("Invalid arguments.");
}
if(!opts.key) {
Function cells
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
Spreadsheets.cells = function(opts, cb) {
if(!opts) {
throw new Error("Invalid arguments.");
}
if(!opts.key) {
Similar blocks of code found in 2 locations. Consider refactoring. Open
it("fails gracefully on unpublished spreadsheets", function(done) {
GoogleSpreadsheets({
key: "1Y9_ldGHQt6SWXsu18BlAWQKYu_axFfowlqhJ97SxEHQ"
}, function(err) {
err.message.should.equal("No access to that spreadsheet, check your auth.");
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 59.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
it("fails gracefully on nonexistent spreadsheets", function(done) {
GoogleSpreadsheets({
key: "BACON"
}, function(err) {
err.message.should.equal("HTTP error 400: Bad Request");
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 59.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function Row
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
var Row = function(data) {
Object.keys(data).forEach(function(key) {
var val;
val = data[key];
if(key.substring(0, 4) === "gsx:") {
Function cells
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Spreadsheets.cells = function(opts, cb) {
if(!opts) {
throw new Error("Invalid arguments.");
}
if(!opts.key) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function rows
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Spreadsheets.rows = function(opts, cb) {
if(!opts) {
throw new Error("Invalid arguments.");
}
if(!opts.key) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this function. Open
return cb(new Error("HTTP error " + response.status + ": " + statuses[response.status]));
Avoid too many return
statements within this function. Open
return cb(new Error("Invalid authorization key."));
Function exports
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Spreadsheets = module.exports = function(opts, cb) {
if(!opts) {
throw new Error("Invalid arguments.");
}
if(!opts.key) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"