Sign upLogin

samizdam/PhamilyFramework

View on GitHub
Star

Showing 93 of 93 total issues

The class Persona has an overall complexity of 53 which is very high. The configured complexity threshold is 50.
Open

class Persona implements PersonaInterface
{
    protected $id;

    protected $gender;
Severity: Minor
Found in src/Model/Persona.php by phpmd

Persona has 26 functions (exceeds 20 allowed). Consider refactoring.
Open

class Persona implements PersonaInterface
{
    protected $id;

    protected $gender;
Severity: Minor
Found in src/Model/Persona.php - About 3 hrs to fix

    Method save has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function save(PersonaInterface $persona)
    {
        /*
         * TODO extract to method?
         * save parents before
    Severity: Major
    Found in src/Repository/PersonaRepository.php - About 2 hrs to fix

      Function save has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          public function save(PersonaInterface $persona)
    {
        /*
         * TODO extract to method?
         * save parents before
      Severity: Minor
      Found in src/Repository/PersonaRepository.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getPredicate has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getPredicate($degreesOfKinship = self::SIBLINGS)
    {
        $siblingCondition = new Where();
        $personaId = $this->personaId;
        $fatherId = $this->fatherId;
      Severity: Major
      Found in src/Repository/Condition/SiblingsQueryCondition.php - About 2 hrs to fix

        Function getPersonaById has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getPersonaById($id, $fetchWithOptions = self::WITHOUT_KINSHIP)
    {
        $options = $fetchWithOptions;

        if ($this->identityMap->has($id)) {
        Severity: Minor
        Found in src/Repository/PersonaRepository.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid excessively long variable names like $spouseRelationshipTableGateway. Keep variable name length under 20.
        Open

                $spouseRelationshipTableGateway = $this->createTableGateway('spouse_relationship');
        Severity: Minor
        Found in src/Repository/PersonaRepository.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Avoid excessively long variable names like $spouseRelationTableGateway. Keep variable name length under 20.
        Open

                $spouseRelationTableGateway = $this->createTableGateway('spouse_relationship');
        Severity: Minor
        Found in src/Repository/PersonaRepository.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Function fetchSpouses has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function fetchSpouses(PersonaInterface $persona, \ArrayAccess $data, $options)
    {
        $spouseRelationshipTableGateway = $this->createTableGateway('spouse_relationship');
        $spouseRelationsSet = [];
        if ($persona->getGender() === $persona::GENDER_MALE) {
        Severity: Minor
        Found in src/Repository/PersonaRepository.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getPersonaById has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getPersonaById($id, $fetchWithOptions = self::WITHOUT_KINSHIP)
    {
        $options = $fetchWithOptions;

        if ($this->identityMap->has($id)) {
        Severity: Minor
        Found in src/Repository/PersonaRepository.php - About 1 hr to fix

          Function isValidSpouse has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function isValidSpouse(PersonaInterface $persona, PersonaInterface $spouse)
    {
        $errors = [];

        if ($persona === $spouse) {
          Severity: Minor
          Found in src/Validator/BaseSpouseValidator.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  if ($this->isFlagSet($degreesOfKinship, self::HALF_SISTER_PATERNAL)) {
            $where = (new Where())->equalTo('father_id', $fatherId)
                ->equalTo('gender', self::GENDER_FEMALE)
                ->notEqualTo('id', $personaId);
          Severity: Major
          Found in src/Repository/Condition/SiblingsQueryCondition.php and 3 other locations - About 1 hr to fix
          src/Repository/Condition/SiblingsQueryCondition.php on lines 52..61
          src/Repository/Condition/SiblingsQueryCondition.php on lines 63..72
          src/Repository/Condition/SiblingsQueryCondition.php on lines 85..94

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  if ($this->isFlagSet($degreesOfKinship, self::HALF_BROTHER_PATERNAL)) {
            $where = (new Where())->equalTo('father_id', $fatherId)
                ->equalTo('gender', self::GENDER_MALE)
                ->notEqualTo('id', $personaId);
          Severity: Major
          Found in src/Repository/Condition/SiblingsQueryCondition.php and 3 other locations - About 1 hr to fix
          src/Repository/Condition/SiblingsQueryCondition.php on lines 63..72
          src/Repository/Condition/SiblingsQueryCondition.php on lines 74..83
          src/Repository/Condition/SiblingsQueryCondition.php on lines 85..94

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  if ($this->isFlagSet($degreesOfKinship, self::HALF_SISTER_MATERNAL)) {
            $where = (new Where())->equalTo('mother_id', $motherId)
                ->equalTo('gender', self::GENDER_FEMALE)
                ->notEqualTo('id', $personaId);
          Severity: Major
          Found in src/Repository/Condition/SiblingsQueryCondition.php and 3 other locations - About 1 hr to fix
          src/Repository/Condition/SiblingsQueryCondition.php on lines 52..61
          src/Repository/Condition/SiblingsQueryCondition.php on lines 63..72
          src/Repository/Condition/SiblingsQueryCondition.php on lines 74..83

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  if ($this->isFlagSet($degreesOfKinship, self::HALF_BROTHER_MATERNAL)) {
            $where = (new Where())->equalTo('mother_id', $motherId)
                ->equalTo('gender', self::GENDER_MALE)
                ->notEqualTo('id', $personaId);
          Severity: Major
          Found in src/Repository/Condition/SiblingsQueryCondition.php and 3 other locations - About 1 hr to fix
          src/Repository/Condition/SiblingsQueryCondition.php on lines 52..61
          src/Repository/Condition/SiblingsQueryCondition.php on lines 74..83
          src/Repository/Condition/SiblingsQueryCondition.php on lines 85..94

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid variables with short names like $id. Configured minimum length is 3.
          Open

              public function has($id)
          Severity: Minor
          Found in src/Repository/PersonaIdentityMap.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $ai. Configured minimum length is 3.
          Open

                      $ai = new SequenceFeature($this->primaryKey, 'persona_id_seq');
          Severity: Minor
          Found in src/Repository/PersonaRepository.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $id. Configured minimum length is 3.
          Open

              protected $id;
          Severity: Minor
          Found in src/Model/Anthroponym.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $id. Configured minimum length is 3.
          Open

              public function getData($id);
          Severity: Minor
          Found in src/Repository/PersonaIdentityMapInterface.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $id. Configured minimum length is 3.
          Open

              protected $id;
          Severity: Minor
          Found in src/Model/Persona.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Severity
          Category
          Status
          Source
          Language