samsonframework/bitbucket-reporter

View on GitHub

Showing 3 of 3 total issues

Function report has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function report(CloudReporter $bitbucket, ConsoleLogger $logger)
    {
        $violations = $this->parseViolations();

        $logger->log(ConsoleLogger::INFO, 'Found '.count($violations, COUNT_RECURSIVE).' violations');
Severity: Minor
Found in src/MessDetectorReporter.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        AuthenticationInterface $credentials,
        ConsoleLogger $logger,
        string $accountName,
        string $repoName,
        int $pullRequestId
Severity: Minor
Found in src/CloudReporter.php - About 35 mins to fix

    Function getChangedFiles has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getChangedFiles()
        {
            $files = [];
            $responseString = $this->pullRequests->commits($this->accountName, $this->repoName, $this->pullRequestId);
    
    
    Severity: Minor
    Found in src/CloudReporter.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language