samsonos/php_compressor

View on GitHub
src/Code.php

Summary

Maintainability
F
1 wk
Test Coverage

Function parse has a Cognitive Complexity of 136 (exceeds 5 allowed). Consider refactoring.
Open

    protected function parse( $path, $module = NULL, & $code = array(), $namespace = self::NS_GLOBAL )
    {
        $_path = $path;
        $path = normalizepath(realpath($path));

Severity: Minor
Found in src/Code.php - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse has 123 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function parse( $path, $module = NULL, & $code = array(), $namespace = self::NS_GLOBAL )
    {
        $_path = $path;
        $path = normalizepath(realpath($path));

Severity: Major
Found in src/Code.php - About 4 hrs to fix

    Method removeUSE has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function removeUSE($code)
        {
            // Find all uses in file
            $matches = array();
            if (preg_match_all(self::PAT_USE, $code, $matches)) {
    Severity: Minor
    Found in src/Code.php - About 1 hr to fix

      Function removeUSE has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function removeUSE($code)
          {
              // Find all uses in file
              $matches = array();
              if (preg_match_all(self::PAT_USE, $code, $matches)) {
      Severity: Minor
      Found in src/Code.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return $main_code;
      Severity: Major
      Found in src/Code.php - About 30 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                            case T_INCLUDE_ONCE:
                            {
                                // Получим путь к подключаемому файлу
                                $file_path = '';
        
        
        Severity: Major
        Found in src/Code.php and 1 other location - About 1 day to fix
        src/Compressor.php on lines 883..933

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 296.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                            case T_NAMESPACE:
        
                                // Определим временное пространство имен
                                $_namespace = '';
        
        
        Severity: Major
        Found in src/Code.php and 1 other location - About 1 day to fix
        src/Compressor.php on lines 831..877

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 287.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                                for ($j = $i+1; $j < sizeof($tokens); $j++)
                                {
                                    // Получим идентификатор метки и текстовое представление
                                    $id = isset( $tokens[ $j ][0] ) ? $tokens[ $j ][0] : '';
                                    $text = isset( $tokens[ $j ][1] ) ? $tokens[ $j ][1] : '';
        Severity: Major
        Found in src/Code.php and 1 other location - About 4 hrs to fix
        src/Compressor.php on lines 762..788

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 168.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if( isset( $this->files[ $path ])  )     return $this->log('    ! Файл: [##], already compressed', $path);
                else if( !is_file($path) )                return $this->log('    ! Файл: [##], не существует', $_path );
                else if(strpos($path, 'vendor/autoload.php') !== false) return $this->log('    Ignoring composer autoloader [##]', $path);
                else if(in_array(basename($path), $this->ignoredFiles)) { return $this->log('    Ignoring file[##] by configuration', $path);}
        Severity: Major
        Found in src/Code.php and 1 other location - About 2 hrs to fix
        src/Compressor.php on lines 669..674

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 130.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status