samsonos/php_compressor

View on GitHub
src/Compressor.php

Summary

Maintainability
F
1 wk
Test Coverage

Function compress_php has a Cognitive Complexity of 213 (exceeds 5 allowed). Consider refactoring.
Open

    public function compress_php($path, $module = NULL, & $code = array(), $namespace = self::NS_GLOBAL)
    {
        // TODO: Довести до ума разпознование require - убрать точку с зяпятоц которая остается
        // TODO: Убрать пустые линии
        // TODO: Анализатор использования функция и переменных??
Severity: Minor
Found in src/Compressor.php - About 4 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Compressor.php has 601 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace samsonphp\compressor;

use samson\core\Core;
use samson\core\iModule;
Severity: Major
Found in src/Compressor.php - About 1 day to fix

    Method compress_php has 208 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function compress_php($path, $module = NULL, & $code = array(), $namespace = self::NS_GLOBAL)
        {
            // TODO: Довести до ума разпознование require - убрать точку с зяпятоц которая остается
            // TODO: Убрать пустые линии
            // TODO: Анализатор использования функция и переменных??
    Severity: Major
    Found in src/Compressor.php - About 1 day to fix

      Function code_array_to_str has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
      Open

          public function code_array_to_str(array $code, $no_ns = false)
          {
              // Соберем весь PHP код модуля
              $php_code = '';
              foreach ($code as $ns => $files) {
      Severity: Minor
      Found in src/Compressor.php - About 7 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function compress has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
      Open

          public function compress($debug = false, $environment = 'prod', $php_version = PHP_VERSION)
          {
              // Set compressed project environment
              $this->environment = $environment;
      
      
      Severity: Minor
      Found in src/Compressor.php - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method compress has 128 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function compress($debug = false, $environment = 'prod', $php_version = PHP_VERSION)
          {
              // Set compressed project environment
              $this->environment = $environment;
      
      
      Severity: Major
      Found in src/Compressor.php - About 5 hrs to fix

        Function code_array_combine has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            public function code_array_combine(array & $source, array & $target)
            {
                foreach ($source as $ns => $files) {
                    // Если в целевом массиве нет нужного NS - создадим
                    if (!isset($target[$ns])) $target[$ns] = array();
        Severity: Minor
        Found in src/Compressor.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function compress_module has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            public function compress_module(iModule &$module, ResourceMap &$data)
            {
                // Идентификатор модуля
                $id = $module->id();
        
        
        Severity: Minor
        Found in src/Compressor.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method code_array_to_str has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function code_array_to_str(array $code, $no_ns = false)
            {
                // Соберем весь PHP код модуля
                $php_code = '';
                foreach ($code as $ns => $files) {
        Severity: Minor
        Found in src/Compressor.php - About 1 hr to fix

          Method compress_module has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function compress_module(iModule &$module, ResourceMap &$data)
              {
                  // Идентификатор модуля
                  $id = $module->id();
          
          
          Severity: Minor
          Found in src/Compressor.php - About 1 hr to fix

            Function removeUSEStatement has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                private function removeUSEStatement($code, array $classes)
                {
                    // Iterate found use statements
                    foreach (array_unique($classes) as $full_class) {
                        // Ignore trait uses
            Severity: Minor
            Found in src/Compressor.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function transformClassName has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                private function transformClassName($source, $className, $php, $ns)
                {
                    // Create copy
                    $nClassName = trim($className);
            
            
            Severity: Minor
            Found in src/Compressor.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function __construct($output = 'out/', $debug = false, $environment = 'prod', $phpVersion = PHP_VERSION, $configuration = array())
            Severity: Minor
            Found in src/Compressor.php - About 35 mins to fix

              Avoid too many return statements within this method.
              Open

                      return $main_code;
              Severity: Major
              Found in src/Compressor.php - About 30 mins to fix

                Function classes_to_ns_files has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function classes_to_ns_files($collection, & $classes = array())
                    {
                        // Соберем коллекцию загруженных интерфейсов их файлов по пространствам имен
                        foreach ($collection as $class) {
                            $ac = new \ReflectionClass($class);
                Severity: Minor
                Found in src/Compressor.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                    case T_INCLUDE_ONCE: {
                                        // Получим путь к подключаемому файлу
                                        $file_path = '';
                
                                        // Переберем все что иде после комманды подключения файла
                Severity: Major
                Found in src/Compressor.php and 1 other location - About 1 day to fix
                src/Code.php on lines 374..429

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 296.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                    case T_NAMESPACE:
                
                                        // Определим временное пространство имен
                                        $_namespace = '';
                
                
                Severity: Major
                Found in src/Compressor.php and 1 other location - About 1 day to fix
                src/Code.php on lines 319..368

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 287.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                        for ($j = $i + 1; $j < sizeof($tokens); $j++) {
                                            // Получим идентификатор метки и текстовое представление
                                            $id = isset($tokens[$j][0]) ? $tokens[$j][0] : '';
                                            $text = isset($tokens[$j][1]) ? $tokens[$j][1] : '';
                
                
                Severity: Major
                Found in src/Compressor.php and 1 other location - About 4 hrs to fix
                src/Code.php on lines 263..288

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 168.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (isset($this->files[$path])) return $this->log('    ! Файл: [##], already compressed', $path);
                        else if (!is_file($path)) return $this->log('    ! Файл: [##], не существует', $_path);
                        else if (strpos($path, 'vendor/autoload.php') !== false) return $this->log('    Ignoring composer autoloader [##]', $path);
                        else if (in_array(basename($path), $this->ignoredFiles)) {
                            return $this->log('    Ignoring file[##] by configuration', $path);
                Severity: Major
                Found in src/Compressor.php and 1 other location - About 2 hrs to fix
                src/Code.php on lines 195..198

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 130.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status