Sign upLogin

samuelchassot/SDP-SwissTeam

View on GitHub
Star
app/src/main/java/ch/epfl/swissteam/services/providers/DBUtility.java

Summary

Maintainability
C
1 day
Test Coverage

DBUtility has 41 methods (exceeds 20 allowed). Consider refactoring.
Open

public class DBUtility {

    public final static String USERS = "Users";
    public final static String CATEGORIES = "Categories";
    public final static String POSTS = "Posts";
Severity: Minor
Found in app/src/main/java/ch/epfl/swissteam/services/providers/DBUtility.java - About 5 hrs to fix

    File DBUtility.java has 261 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package ch.epfl.swissteam.services.providers;

import android.app.Activity;
import android.location.Location;
import android.support.annotation.NonNull;
    Severity: Minor
    Found in app/src/main/java/ch/epfl/swissteam/services/providers/DBUtility.java - About 2 hrs to fix

      Method notifyNewMessages has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public void notifyNewMessages(Activity activity, String googleId) {
        if (!isNotificationsSetupDone && googleId != null) {
            db_.child(USERS).child(googleId).child("chatRelations_").addChildEventListener(new ChildEventListener() {
                @Override
                public void onChildAdded(@NonNull DataSnapshot relationDataSnapshot, @Nullable String s) {
      Severity: Minor
      Found in app/src/main/java/ch/epfl/swissteam/services/providers/DBUtility.java - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                db_.child(DBUtility.CHATS).child(chatRelationId).addListenerForSingleValueEvent(new ValueEventListener() {
            ArrayList<ChatMessage> messages = new ArrayList<>();
            @Override
            public void onDataChange(@NonNull DataSnapshot dataSnapshot) {
                for (DataSnapshot data : dataSnapshot.getChildren()) {
        Severity: Minor
        Found in app/src/main/java/ch/epfl/swissteam/services/providers/DBUtility.java and 1 other location - About 40 mins to fix
        app/src/main/java/ch/epfl/swissteam/services/providers/DBUtility.java on lines 160..174

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                db_.child(USERS).addListenerForSingleValueEvent(new ValueEventListener() {
            ArrayList<User> users = new ArrayList<>();

            @Override
            public void onDataChange(@NonNull DataSnapshot dataSnapshot) {
        Severity: Minor
        Found in app/src/main/java/ch/epfl/swissteam/services/providers/DBUtility.java and 1 other location - About 40 mins to fix
        app/src/main/java/ch/epfl/swissteam/services/providers/DBUtility.java on lines 179..192

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status