Sign upLogin

samuelchassot/SDP-SwissTeam

View on GitHub
Star
app/src/main/java/ch/epfl/swissteam/services/view/fragments/ServicesFragment.java

Summary

Maintainability
B
4 hrs
Test Coverage

Method onCreateView has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container,
                             Bundle savedInstanceState) {
        View view = inflater.inflate(R.layout.fragment_services, container, false);
Severity: Major
Found in app/src/main/java/ch/epfl/swissteam/services/view/fragments/ServicesFragment.java - About 2 hrs to fix

    Method initDataSet has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private void initDataSet(Categories category, ArrayList<String> keywords) {
        ActivityUtils.hideKeyboard(this.getActivity());
        View view = getView();
        if (category == Categories.ALL) {
            DBUtility.get().getAllUsers((usersdb -> {
    Severity: Minor
    Found in app/src/main/java/ch/epfl/swissteam/services/view/fragments/ServicesFragment.java - About 1 hr to fix

      Method userContainsKeywords has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          private boolean userContainsKeywords(User u, ArrayList<String> kw, Categories cat){
        ArrayList<String> listForCat;
        if(cat.compareTo(Categories.ALL) == 0){
            listForCat = new ArrayList<>();
               for(Categories c : Categories.values()){
      Severity: Minor
      Found in app/src/main/java/ch/epfl/swissteam/services/view/fragments/ServicesFragment.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status