Sign upLogin

sanger/limber

View on GitHub
Star
app/models/labware_creators/stamped_plate_adding_randomised_controls.rb

Summary

Maintainability
B
4 hrs
Test Coverage
B
89%

Class StampedPlateAddingRandomisedControls has 30 methods (exceeds 20 allowed). Consider refactoring.
Open

  class StampedPlateAddingRandomisedControls < StampedPlate # rubocop:todo Metrics/ClassLength
    PARENT_PLATE_INCLUDES =
      'wells.requests_as_source,wells.requests_as_source.request_type,' \
        'wells.aliquots,wells.aliquots.sample,wells.aliquots.sample.sample_metadata'
Severity: Minor
Found in app/models/labware_creators/stamped_plate_adding_randomised_controls.rb - About 3 hrs to fix

    Method check_control_rules_from_config has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def check_control_rules_from_config(control_locations)
      list_of_rules.each do |rule|
        case rule.type
        when 'not'
          # locations must not match this combination of wells (order is important)
    Severity: Minor
    Found in app/models/labware_creators/stamped_plate_adding_randomised_controls.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status