Sign upLogin

sanger/sequencescape

View on GitHub
Star
app/api/model_extensions/stamp.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

ModelExtensions::Stamp#locate_qcable doesn't depend on instance state (maybe move it to another class?)
Open

  def locate_qcable(d)
Severity: Minor
Found in app/api/model_extensions/stamp.rb by reek

A Utility Function is any instance method that has no dependency on the state of the instance.

ModelExtensions::Stamp#locate_qcable has the parameter name 'd'
Open

  def locate_qcable(d)
Severity: Minor
Found in app/api/model_extensions/stamp.rb by reek

An Uncommunicative Parameter Name is a parameter name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ModelExtensions::Stamp#stamp_details= has the variable name 'd'
Open

    stamp_qcables.build(details.map { |d| locate_qcable(d) })
Severity: Minor
Found in app/api/model_extensions/stamp.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

There are no issues that match your filters.

Category
Status