Sign upLogin

sanger/sequencescape

View on GitHub
Star
app/controllers/sdb/sample_manifests_controller.rb

Summary

Maintainability
A
0 mins
Test Coverage
C
78%

Complex method Sdb::SampleManifestsController#new (29.8)
Open

  def new # rubocop:todo Metrics/AbcSize
    params[:only_first_label] ||= false
    @sample_manifest = SampleManifest.new(new_manifest_params)
    @study_id = params[:study_id] || ''
    @studies = Study.alphabetical.pluck(:name, :id)
Severity: Minor
Found in app/controllers/sdb/sample_manifests_controller.rb by flog

Flog calculates the ABC score for methods. The ABC score is based on assignments, branches (method calls), and conditions.

You can read more about ABC metrics or the flog tool

Sdb::SampleManifestsController#new has approx 9 statements
Open

  def new # rubocop:todo Metrics/AbcSize
Severity: Minor
Found in app/controllers/sdb/sample_manifests_controller.rb by reek

A method with Too Many Statements is any method that has a large number of lines.

Too Many Statements warns about any method that has more than 5 statements. Reek's smell detector for Too Many Statements counts +1 for every simple statement in a method and +1 for every statement within a control structure (if, else, case, when, for, while, until, begin, rescue) but it doesn't count the control structure itself.

So the following method would score +6 in Reek's statement-counting algorithm:

def parse(arg, argv, &error)
  if !(val = arg) and (argv.empty? or /\A-/ =~ (val = argv[0]))
    return nil, block, nil                                         # +1
  end
  opt = (val = parse_arg(val, &error))[1]                          # +2
  val = conv_arg(*val)                                             # +3
  if opt and !arg
    argv.shift                                                     # +4
  else
    val[0] = nil                                                   # +5
  end
  val                                                              # +6
end

(You might argue that the two assigments within the first @if@ should count as statements, and that perhaps the nested assignment should count as +2.)

Sdb::SampleManifestsController has at least 13 instance variables
Open

class Sdb::SampleManifestsController < Sdb::BaseController
Severity: Minor
Found in app/controllers/sdb/sample_manifests_controller.rb by reek

Too Many Instance Variables is a special case of LargeClass.

Example

Given this configuration

TooManyInstanceVariables:
  max_instance_variables: 3

and this code:

class TooManyInstanceVariables
  def initialize
    @arg_1 = :dummy
    @arg_2 = :dummy
    @arg_3 = :dummy
    @arg_4 = :dummy
  end
end

Reek would emit the following warning:

test.rb -- 5 warnings:
  [1]:TooManyInstanceVariables has at least 4 instance variables (TooManyInstanceVariables)

Complex method Sdb::SampleManifestsController#create (23.3)
Open

  def create # rubocop:todo Metrics/AbcSize
    @sample_manifest_generator =
      SampleManifest::Generator.new(params[:sample_manifest], current_user, SampleManifestExcel.configuration)

    if @sample_manifest_generator.execute
Severity: Minor
Found in app/controllers/sdb/sample_manifests_controller.rb by flog

Flog calculates the ABC score for methods. The ABC score is based on assignments, branches (method calls), and conditions.

You can read more about ABC metrics or the flog tool

Sdb::SampleManifestsController#validate_type calls 'params[:asset_type]' 2 times
Open

    return true if SampleManifest.supported_asset_type?(params[:asset_type])

    flash[:error] = "'#{params[:asset_type]}' is not a supported manifest type."
Severity: Minor
Found in app/controllers/sdb/sample_manifests_controller.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Sdb::SampleManifestsController#uploaded_spreadsheet calls '@manifest.uploaded_document' 3 times
Open

      @manifest.uploaded_document.current_data,
      filename: @manifest.uploaded_document.filename,
      type: @manifest.uploaded_document.content_type || 'application/vnd.ms-excel'
Severity: Minor
Found in app/controllers/sdb/sample_manifests_controller.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Sdb::SampleManifestsController#new calls 'params[:asset_type]' 2 times
Open

    @rack_purposes = @sample_manifest.acceptable_rack_purposes.pluck(:name, :id) if params[:asset_type] == 'tube_rack'
    @barcode_printers = @sample_manifest.applicable_barcode_printers.pluck(:name)
    @templates = SampleManifestExcel.configuration.manifest_types.by_asset_type(params[:asset_type]).to_a
Severity: Minor
Found in app/controllers/sdb/sample_manifests_controller.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Sdb::SampleManifestsController#index calls 'params[:page]' 3 times
Open

      SampleManifest.pending_manifests.includes(:study, :supplier, :user).paginate(page: params[:page])
    completed_sample_manifests =
      SampleManifest.completed_manifests.includes(:study, :supplier, :user).paginate(page: params[:page])
    @display_manifests = pending_sample_manifests | completed_sample_manifests
    @sample_manifests = SampleManifest.paginate(page: params[:page])
Severity: Minor
Found in app/controllers/sdb/sample_manifests_controller.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

There are no issues that match your filters.

Category
Status