Sign upLogin

sanger/sequencescape

View on GitHub
Star
app/controllers/submissions_controller.rb

Summary

Maintainability
A
0 mins
Test Coverage
D
66%

SubmissionsController has at least 6 instance variables
Open

class SubmissionsController < ApplicationController
Severity: Minor
Found in app/controllers/submissions_controller.rb by reek

Too Many Instance Variables is a special case of LargeClass.

Example

Given this configuration

TooManyInstanceVariables:
  max_instance_variables: 3

and this code:

class TooManyInstanceVariables
  def initialize
    @arg_1 = :dummy
    @arg_2 = :dummy
    @arg_3 = :dummy
    @arg_4 = :dummy
  end
end

Reek would emit the following warning:

test.rb -- 5 warnings:
  [1]:TooManyInstanceVariables has at least 4 instance variables (TooManyInstanceVariables)

SubmissionsController#change_priority calls 'params[:id]' 2 times
Open

    Submission.find(params[:id]).update!(priority: params[:submission][:priority])
    redirect_to action: :show, id: params[:id]
Severity: Minor
Found in app/controllers/submissions_controller.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

SubmissionsController#index calls 'current_user.id' 3 times
Open

    @building = Submission.building.order(created_at: :desc).where(user_id: current_user.id)
    @pending = Submission.pending.order(created_at: :desc).where(user_id: current_user.id)
    @ready = Submission.ready.order(created_at: :desc).limit(10).where(user_id: current_user.id)
Severity: Minor
Found in app/controllers/submissions_controller.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

SubmissionsController#update calls '@presenter.submission.errors' 2 times
Open

    if @presenter.submission.errors.present?
      flash[:error] = "The submission could not be built: #{@presenter.submission.errors.full_messages}"
Severity: Minor
Found in app/controllers/submissions_controller.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

SubmissionsController#cancel calls 'params[:id]' 2 times
Open

    submission = Submission.find(params[:id])
    submission.cancel!
    redirect_to action: :show, id: params[:id]
Severity: Minor
Found in app/controllers/submissions_controller.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

SubmissionsController#update calls '@presenter.submission' 3 times
Open

    if @presenter.submission.errors.present?
      flash[:error] = "The submission could not be built: #{@presenter.submission.errors.full_messages}"
    end

    redirect_to @presenter.submission
Severity: Minor
Found in app/controllers/submissions_controller.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Complex method SubmissionsController#index (21.8)
Open

  def index # rubocop:todo Metrics/AbcSize
    # Disable cache of this page
    expires_now

    @building = Submission.building.order(created_at: :desc).where(user_id: current_user.id)
Severity: Minor
Found in app/controllers/submissions_controller.rb by flog

Flog calculates the ABC score for methods. The ABC score is based on assignments, branches (method calls), and conditions.

You can read more about ABC metrics or the flog tool

TODO found
Open

  # TODO[sd9]: These AJAX routes could be re-factored
Severity: Minor
Found in app/controllers/submissions_controller.rb by fixme

There are no issues that match your filters.

Category
Status