app/controllers/tube_rack_summaries_controller.rb from sanger/sequencescape

app/controllers/tube_rack_summaries_controller.rb

0 mins

100%

    raise ActiveRecord::RecordNotFound if @tube_rack.nil?

A NilCheck is a type check. Failures of NilCheck violate the "tell, don't ask" principle.

Additionally, type checks often mask bigger problems in your source code like not using OOP and / or polymorphism when you should.

Example

Given

class Klass
  def nil_checker(argument)
    if argument.nil?
      puts "argument isn't nil!"
    end
  end
end

Reek would emit the following warning:

test.rb -- 1 warning:
  [3]:Klass#nil_checker performs a nil-check. (NilCheck)