Sign upLogin

sanger/sequencescape

View on GitHub
Star
app/models/api/sample_io.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
97%

Complex method Api::SampleIO::with_association#sample_metadata (54.9)
Open

  with_association(:sample_metadata) do
    map_attribute_to_json_attribute(:organism)
    map_attribute_to_json_attribute(:cohort)
    map_attribute_to_json_attribute(:country_of_origin)
    map_attribute_to_json_attribute(:geographical_region)
Severity: Minor
Found in app/models/api/sample_io.rb by flog

Flog calculates the ABC score for methods. The ABC score is based on assignments, branches (method calls), and conditions.

You can read more about ABC metrics or the flog tool

Api::SampleIO::Extensions has no descriptive comment
Open

  module Extensions
Severity: Minor
Found in app/models/api/sample_io.rb by reek

Classes and modules are the units of reuse and release. It is therefore considered good practice to annotate every class and module with a brief comment outlining its responsibilities.

Example

Given

class Dummy
  # Do things...
end

Reek would emit the following warning:

test.rb -- 1 warning:
  [1]:Dummy has no descriptive comment (IrresponsibleModule)

Fixing this is simple - just an explaining comment:

# The Dummy class is responsible for ...
class Dummy
  # Do things...
end

Api::SampleIO::Extensions::ClassMethods has no descriptive comment
Open

    module ClassMethods
Severity: Minor
Found in app/models/api/sample_io.rb by reek

Classes and modules are the units of reuse and release. It is therefore considered good practice to annotate every class and module with a brief comment outlining its responsibilities.

Example

Given

class Dummy
  # Do things...
end

Reek would emit the following warning:

test.rb -- 1 warning:
  [1]:Dummy has no descriptive comment (IrresponsibleModule)

Fixing this is simple - just an explaining comment:

# The Dummy class is responsible for ...
class Dummy
  # Do things...
end

There are no issues that match your filters.

Category
Status