Sign upLogin

sanger/sequencescape

View on GitHub
Star
app/models/cherrypick_task.rb

Summary

Maintainability
B
4 hrs
Test Coverage
A
95%

Method perform_pick has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def perform_pick(requests, robot, control_source_plate, workflow_controller) # rubocop:todo Metrics/AbcSize
    max_plates = robot.max_beds
    raise StandardError, 'The chosen robot has no beds!' if max_plates.zero?

    destination_plates = []
Severity: Minor
Found in app/models/cherrypick_task.rb - About 1 hr to fix

    Method perform_pick has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def perform_pick(requests, robot, control_source_plate, workflow_controller) # rubocop:todo Metrics/AbcSize
    max_plates = robot.max_beds
    raise StandardError, 'The chosen robot has no beds!' if max_plates.zero?

    destination_plates = []
    Severity: Minor
    Found in app/models/cherrypick_task.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method pick_onto_partial_plate has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        requests,
    template,
    robot,
    partial_plate,
    control_source_plate = nil,
    Severity: Minor
    Found in app/models/cherrypick_task.rb - About 45 mins to fix

      Method pick_new_plate has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def pick_new_plate(requests, template, robot, plate_purpose, control_source_plate = nil, workflow_controller = nil)
      Severity: Minor
      Found in app/models/cherrypick_task.rb - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status