Sign upLogin

sanger/sequencescape

View on GitHub
Star
app/models/map.rb

Summary

Maintainability
B
5 hrs
Test Coverage
A
94%

Class Map has 38 methods (exceeds 20 allowed). Consider refactoring.
Open

class Map < ApplicationRecord
  validates :description, :asset_size, :location_id, :row_order, :column_order, :asset_shape, presence: true
  validates :asset_size, :row_order, :column_order, numericality: true

  # @!attribute description
Severity: Minor
Found in app/models/map.rb - About 5 hrs to fix

    Method alternate_position has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def alternate_position(well_position, size, *dimensions)
        return nil unless Map.valid_well_position?(well_position)

        divisor, multiplier = dimensions.map { |n| send(:"plate_#{n}", size) }
        return nil if divisor.nil? || multiplier.nil?
    Severity: Minor
    Found in app/models/map.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status