app/models/order.rb
Class Order
has 38 methods (exceeds 20 allowed). Consider refactoring. Open
Open
class Order < ApplicationRecord # rubocop:todo Metrics/ClassLength
# Ensure order methods behave correctly
AssetTypeError = Class.new(StandardError)
DEFAULT_ASSET_INPUT_METHODS = ['select an asset group'].freeze
Method create_request_of_type!
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
def create_request_of_type!(request_type, attributes = {}) # rubocop:todo Metrics/AbcSize
em = request_type.extract_metadata_from_hash(request_options)
request_type.create!(attributes) do |request|
request.submission_id = submission_id
request.study = study
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"