app/models/tasks/cherrypick_handler.rb
Method do_cherrypick_task
has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring. Open
Open
def do_cherrypick_task(_task, params) # rubocop:todo Metrics/CyclomaticComplexity
plates = params[:plate]
size = params[:plate_size]
plate_type = params[:plate_type]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method do_cherrypick_task
has 94 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def do_cherrypick_task(_task, params) # rubocop:todo Metrics/CyclomaticComplexity
plates = params[:plate]
size = params[:plate_size]
plate_type = params[:plate_type]
Method render_cherrypick_task
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
Open
def render_cherrypick_task(_task, params) # rubocop:todo Metrics/CyclomaticComplexity
if flash[:error].present?
redirect_to action: 'stage', batch_id: @batch.id, workflow_id: @workflow.id, id: (@stage - 1).to_s
return
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method render_cherrypick_task
has 48 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def render_cherrypick_task(_task, params) # rubocop:todo Metrics/CyclomaticComplexity
if flash[:error].present?
redirect_to action: 'stage', batch_id: @batch.id, workflow_id: @workflow.id, id: (@stage - 1).to_s
return
end