Sign upLogin

sanger/sequencescape

View on GitHub
Star
app/models/transfer_request.rb

Summary

Maintainability
A
1 hr
Test Coverage
A
99%

Method perform_transfer_of_contents has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def perform_transfer_of_contents
    return if asset.failed? || asset.cancelled?

    target_asset.aliquots << aliquots_for_transfer
  rescue ActiveRecord::RecordNotUnique => e
Severity: Minor
Found in app/models/transfer_request.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method on_started has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def on_started
    sibling_requests.each do |sr|
      # We only want to start the matching requests. The conditional deals with situations
      # which pre-date aliquot association with request.
      next unless target_aliquot_requests.blank? || target_aliquot_requests.ids.include?(sr.id)
Severity: Minor
Found in app/models/transfer_request.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status