Sign upLogin

sanger/sequencescape

View on GitHub
Star
app/warren/subscribers/queue_broadcast_consumer.rb

Summary

Maintainability
A
35 mins
Test Coverage
F
30%

Warren::Subscriber::QueueBroadcastConsumer#extract_json has approx 6 statements
Open

  def extract_json
Severity: Minor
Found in app/warren/subscribers/queue_broadcast_consumer.rb by reek

A method with Too Many Statements is any method that has a large number of lines.

Too Many Statements warns about any method that has more than 5 statements. Reek's smell detector for Too Many Statements counts +1 for every simple statement in a method and +1 for every statement within a control structure (if, else, case, when, for, while, until, begin, rescue) but it doesn't count the control structure itself.

So the following method would score +6 in Reek's statement-counting algorithm:

def parse(arg, argv, &error)
  if !(val = arg) and (argv.empty? or /\A-/ =~ (val = argv[0]))
    return nil, block, nil                                         # +1
  end
  opt = (val = parse_arg(val, &error))[1]                          # +2
  val = conv_arg(*val)                                             # +3
  if opt and !arg
    argv.shift                                                     # +4
  else
    val[0] = nil                                                   # +5
  end
  val                                                              # +6
end

(You might argue that the two assigments within the first @if@ should count as statements, and that perhaps the nested assignment should count as +2.)

Method extract_json has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def extract_json
    json = JSON.parse(payload)
    raise InvalidPayload, "Payload #{payload} is not an array" unless json.is_a?(Array)
    raise InvalidPayload, "Payload #{payload} is not the correct length" unless json.length == 2
Severity: Minor
Found in app/warren/subscribers/queue_broadcast_consumer.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Warren::Subscriber::QueueBroadcastConsumer#extract_json has the variable name 'e'
Open

  rescue JSON::ParserError => e
Severity: Minor
Found in app/warren/subscribers/queue_broadcast_consumer.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

There are no issues that match your filters.

Category
Status