Sign upLogin

sanger/sequencescape

View on GitHub
Star
lib/oligo_enumerator.rb

Summary

Maintainability
A
0 mins
Test Coverage
F
54%

OligoEnumerator#tag doesn't depend on instance state (maybe move it to another class?)
Open

  def tag(i)
Severity: Minor
Found in lib/oligo_enumerator.rb by reek

A Utility Function is any instance method that has no dependency on the state of the instance.

OligoEnumerator#each has the variable name 'i'
Open

    @size.times { |i| yield tag(i + @initial) }
Severity: Minor
Found in lib/oligo_enumerator.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

OligoEnumerator#tag has the parameter name 'i'
Open

  def tag(i)
Severity: Minor
Found in lib/oligo_enumerator.rb by reek

An Uncommunicative Parameter Name is a parameter name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

There are no issues that match your filters.

Category
Status