Sign upLogin

sanmai/LazyLINQ

View on GitHub
Star
src/LazyLINQ/Collection.php

Summary

Maintainability
A
1 hr
Test Coverage

Method distinct has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function distinct(callable $comparer = null, bool $strict = false): Interfaces\Collection
    {
        $this->pipeline->map(static function ($value) use ($comparer, $strict) {
            static $previous;
            static $previousSeen = false;
Severity: Minor
Found in src/LazyLINQ/Collection.php - About 1 hr to fix

    Function min has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public function min(callable $selector = null)
    {
        if ($selector) {
            $this->pipeline->map($selector);
        }
    Severity: Minor
    Found in src/LazyLINQ/Collection.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class "Collection" has 47 methods, which is greater than 20 authorized. Split it into smaller classes.
    Wontfix

    final class Collection implements Interfaces\Collection
    Severity: Major
    Found in src/LazyLINQ/Collection.php by sonar-php

    A class that grows too much tends to aggregate too many responsibilities and inevitably becomes harder to understand and therefore to maintain. Above a specific threshold, it is strongly advised to refactor the class into smaller ones which focus on well defined topics.

    Remove this commented out code.
    Open

             * $this->getIterator()->rewind();
    Severity: Major
    Found in src/LazyLINQ/Collection.php by sonar-php

    Programmers should not comment out code as it bloats programs and reduces readability.

    Unused code should be deleted and can be retrieved from source control history if required.

    See

    • MISRA C:2004, 2.4 - Sections of code should not be "commented out".
    • MISRA C++:2008, 2-7-2 - Sections of code shall not be "commented out" using C-style comments.
    • MISRA C++:2008, 2-7-3 - Sections of code should not be "commented out" using C++ comments.
    • MISRA C:2012, Dir. 4.4 - Sections of code should not be "commented out"

    There are no issues that match your filters.

    Category
    Status