app/Http/Controllers/AccountController.php
The method createUser has a boolean flag argument $newUser, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function createUser(Request $request, array $userInfo, bool $newUser = false, bool $sendEmail = false): User- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
The method createUser has a boolean flag argument $sendEmail, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function createUser(Request $request, array $userInfo, bool $newUser = false, bool $sendEmail = false): User- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Avoid assigning values to variables in if clauses and the like (line '197', column '14'). Open
Open
public function forgotPassword(Request $request): JsonResponse
{
if (($user = User::where('mail', $request->json()->get('email'))->first()) == null) {
return response()->json(['email' => $request->json()->get('email')]);
}- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
TODO found Open
Open
* @TODO: Code Integration with HabboMessenger- Exclude checks
TODO found Open
Open
* @TODO: Create Messenger Model- Exclude checks