Sign upLogin

sant0ro/chocolatey

View on GitHub
Star
app/Models/User.php

Summary

Maintainability
A
2 hrs
Test Coverage

User has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

class User extends Model implements AuthenticatableContract, AuthorizableContract
{
    use Authenticatable, Authorizable, Eloquence, Mappable;

    /**
Severity: Minor
Found in app/Models/User.php - About 2 hrs to fix

    The method store has a boolean flag argument $newUser, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function store(string $username, string $email, string $address = '', bool $newUser = true): self
    Severity: Minor
    Found in app/Models/User.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    TODO found
    Invalid

         * @TODO: Implement this in a proper way
    Severity: Minor
    Found in app/Models/User.php by fixme

    There are no issues that match your filters.

    Category
    Status