Sign upLogin

sant0ro/chocolatey

View on GitHub
Star

Showing 90 of 91 total issues

Remove error control operator '@' on line 35.
Open

    public function destroy()
    {
        @session_destroy();
    }
Severity: Minor
Found in app/Helpers/Session.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Remove error control operator '@' on line 27.
Open

    public function start()
    {
        @session_start();
    }
Severity: Minor
Found in app/Helpers/Session.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

The method store has a boolean flag argument $newUser, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function store(string $username, string $email, string $address = '', bool $newUser = true): self
Severity: Minor
Found in app/Models/User.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method createUser has a boolean flag argument $sendEmail, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function createUser(Request $request, array $userInfo, bool $newUser = false, bool $sendEmail = false): User
Severity: Minor
Found in app/Http/Controllers/AccountController.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Avoid unused parameters such as '$request'.
Open

    public function success(Request $request, string $paymentCategory, int $countryCode, int $shopItem, int $paymentMethod)
Severity: Minor
Found in app/Http/Controllers/ShopController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$schedule'.
Open

    protected function schedule(Schedule $schedule)
Severity: Minor
Found in app/Console/Kernel.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$interstitialType'.
Open

    public function getInterstitial(string $interstitialType): Response
Severity: Minor
Found in app/Http/Controllers/ClientController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$roomRange'.
Open

    public function getLeader($countryId, $roomRange, $roomInterval): JsonResponse
Severity: Minor
Found in app/Http/Controllers/RoomsController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid assigning values to variables in if clauses and the like (line '197', column '14').
Open

    public function forgotPassword(Request $request): JsonResponse
    {
        if (($user = User::where('mail', $request->json()->get('email'))->first()) == null) {
            return response()->json(['email' => $request->json()->get('email')]);
        }
Severity: Minor
Found in app/Http/Controllers/AccountController.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid unused parameters such as '$countryId'.
Open

    public function one(string $countryId, string $articleName): Response
Severity: Minor
Found in app/Http/Controllers/ArticleController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$roomInterval'.
Open

    public function getLeader($countryId, $roomRange, $roomInterval): JsonResponse
Severity: Minor
Found in app/Http/Controllers/RoomsController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$chocolateyId'.
Open

    private function checkForBanAlternative(Request $request, ChocolateyId $chocolateyId)
Severity: Minor
Found in app/Helpers/User.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$countryId'.
Open

    protected function category(string $countryId, ArticleCategory $category, int $categoryPage, int $start): Response
Severity: Minor
Found in app/Http/Controllers/ArticleController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$request'.
Open

    public function getPurse(Request $request): JsonResponse
Severity: Minor
Found in app/Http/Controllers/ShopController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid assigning values to variables in if clauses and the like (line '79', column '14').
Open

    public function one(string $countryId, string $articleName): Response
    {
        if (($article = Article::find(strstr($articleName, '_', true))) == null) {
            return response()->json(null, 404);
        }
Severity: Minor
Found in app/Http/Controllers/ArticleController.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid unused parameters such as '$request'.
Open

    public function getUrl(Request $request)
Severity: Minor
Found in app/Http/Controllers/ClientController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid assigning values to variables in if clauses and the like (line '146', column '14').
Open

    public function redeem(Request $request): JsonResponse
    {
        if (($voucher = Voucher::where('code', $request->json()->get('voucherCode'))->first()) == null) {
            return response()->json(null, 404);
        }
Severity: Minor
Found in app/Http/Controllers/ShopController.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid unused parameters such as '$request'.
Open

        $this->app['auth']->viaRequest('api', function ($request) {
Severity: Minor
Found in app/Providers/AuthServiceProvider.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The method store has 10 parameters. Consider reducing the number of parameters to less than 10.
Open

    public function store(string $roomName, string $description, string $model, int $maxUsers, int $roomCategory, int $floorPaper, int $wallPaper, float $landscapePaper, int $ownerId, string $ownerName)
    {
        $this->attributes['name'] = $roomName;
        $this->attributes['description'] = $description;
        $this->attributes['model'] = $model;
Severity: Minor
Found in app/Models/Room.php by phpmd

Avoid unused parameters such as '$value'.
Open

    public function setUpdatedAt($value)
Severity: Minor
Found in app/Models/ChocolateyModel.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Severity
Category
Status
Source
Language