Sign upLogin

sapristi-tool/sapristi

View on GitHub
Star
lib/sapristi/adapters/linux/process_manager.rb

Summary

Maintainability
A
0 mins
Test Coverage

Sapristi::Linux::ProcessManager#self.execute_and_detach calls 'Process.getpgrp' 2 times
Open

          Process.spawn(cmd, out: [out, 'a'], err: [err, 'a'], pgroup: Process.getpgrp)
        rescue StandardError
          raise Error, "Error executing process: #{$ERROR_INFO}"
        end
        ::Sapristi.logger.info "Launch #{cmd.split[0]}, process=#{process_pid} pgroup=#{Process.getpgrp}"
Severity: Minor
Found in lib/sapristi/adapters/linux/process_manager.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Line is too long. [105/80]
Open

        ::Sapristi.logger.info "Launch #{cmd.split[0]}, process=#{process_pid} pgroup=#{Process.getpgrp}"
Severity: Minor
Found in lib/sapristi/adapters/linux/process_manager.rb by rubocop

Line is too long. [87/80]
Open

          Process.spawn(cmd, out: [out, 'a'], err: [err, 'a'], pgroup: Process.getpgrp)
Severity: Minor
Found in lib/sapristi/adapters/linux/process_manager.rb by rubocop

There are no issues that match your filters.

Category
Status