Sign upLogin

savonarola/pulse_meter_core

View on GitHub
Star
lib/pulse_meter/sensor/timeline.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Class Timeline has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Timeline < Base
      include PulseMeter::Mixins::Utils
      include PulseMeter::Sensor::TimelineReduce

      MAX_TIMESPAN_POINTS = 1000
Severity: Minor
Found in lib/pulse_meter/sensor/timeline.rb - About 2 hrs to fix

    Method drop_within has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def drop_within(from, till)
        raise ArgumentError unless from.kind_of?(Time) && till.kind_of?(Time)
        start_time, end_time = time_to_redis(from.to_i), time_to_redis(till.to_i)
        current_interval_id = get_interval_id(start_time) + interval
        keys = []
    Severity: Minor
    Found in lib/pulse_meter/sensor/timeline.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status