savonrb/wasabi

View on GitHub

Showing 11 of 11 total issues

Method input_output_for has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    def input_output_for(operation, input_output)
      operation_name = operation['name']

      # Look up the input by walking up to portType, then up to the message.

Severity: Minor
Found in lib/wasabi/parser.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Parser has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Parser

    XSD      = 'http://www.w3.org/2001/XMLSchema'
    WSDL     = 'http://schemas.xmlsoap.org/wsdl/'
    SOAP_1_1 = 'http://schemas.xmlsoap.org/wsdl/soap/'
Severity: Minor
Found in lib/wasabi/parser.rb - About 2 hrs to fix

    Class Document has 21 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class Document
    
        ELEMENT_FORM_DEFAULTS = [:unqualified, :qualified]
    
        # Validates if a given +value+ is a valid elementFormDefault value.
    Severity: Minor
    Found in lib/wasabi/document.rb - About 2 hrs to fix

      Method input_output_for has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def input_output_for(operation, input_output)
            operation_name = operation['name']
      
            # Look up the input by walking up to portType, then up to the message.
      
      
      Severity: Minor
      Found in lib/wasabi/parser.rb - About 1 hr to fix

        Method process_type has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def process_type(namespace, type, name)
              @types[name] ||= { :namespace => namespace }
              @types[name][:order!] = []
        
              type.xpath('./xs:sequence/xs:element', 'xs' => XSD).each do |inner|
        Severity: Minor
        Found in lib/wasabi/parser.rb - About 1 hr to fix

          Method process_type has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              def process_type(namespace, type, name)
                @types[name] ||= { :namespace => namespace }
                @types[name][:order!] = []
          
                type.xpath('./xs:sequence/xs:element', 'xs' => XSD).each do |inner|
          Severity: Minor
          Found in lib/wasabi/parser.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method parse_operations has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              def parse_operations
                operations = document.xpath('wsdl:definitions/wsdl:binding/wsdl:operation', 'wsdl' => WSDL)
                operations.each do |operation|
                  name = operation.attribute('name').to_s
                  snakecase_name = Wasabi::CoreExt::String.snakecase(name).to_sym
          Severity: Minor
          Found in lib/wasabi/parser.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method parse_types has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def parse_types
                schemas.each do |schema|
                  schema_namespace = schema['targetNamespace']
          
                  schema.element_children.each do |node|
          Severity: Minor
          Found in lib/wasabi/parser.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method parse_operations_parameters has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def parse_operations_parameters
                 document.xpath("wsdl:definitions/wsdl:types/*[local-name()='schema']/*[local-name()='element']", 'wsdl' => WSDL).each do |element|
                  name = Wasabi::CoreExt::String.snakecase(element.attribute('name').to_s).to_sym
          
                  if operation = @operations[name]
          Severity: Minor
          Found in lib/wasabi/parser.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def parse_messages
                messages = document.root.element_children.select { |node| node.name == 'message' }
                @messages = Hash[messages.map { |node| [node['name'], node] }]
          Severity: Minor
          Found in lib/wasabi/parser.rb and 1 other location - About 15 mins to fix
          lib/wasabi/parser.rb on lines 108..110

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 25.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def parse_port_types
                port_types = document.root.element_children.select { |node| node.name == 'portType' }
                @port_types = Hash[port_types.map { |node| [node['name'], node] }]
          Severity: Minor
          Found in lib/wasabi/parser.rb and 1 other location - About 15 mins to fix
          lib/wasabi/parser.rb on lines 103..105

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 25.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language