Sign upLogin

scaljeri/javascript-dependency-injection

View on GitHub
Star

Showing 6 of 13 total issues

Function register has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    register(contractStr, classRef, params = [], options = {}) {
        let paramsOrigin = 'input';

        if (Array.isArray(classRef)) {
            options = params;
Severity: Major
Found in di.js - About 2 hrs to fix

    Function register has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        register(contractStr, classRef, params = [], options = {}) {
        let paramsOrigin = 'input';

        if (Array.isArray(classRef)) {
            options = params;
    Severity: Minor
    Found in di.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function mergeParams has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        mergeParams(contract, params = []) {
        let baseParams
                , indexParams = 0
                , mergedParams = [];
    Severity: Minor
    Found in di.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function augment has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        augment(classRef, options) {
        let di = this
                , newClassRef = classRef
                , contractList = classRef.toString().match(/@inject\s*:*\s*([^\n]+)/);
    Severity: Minor
    Found in di.js - About 1 hr to fix

      Function getInstance has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          getInstance(contractStr, ...params) {
        let instance = null
                , contract = this.contracts[contractStr];

        if (contract) {
      Severity: Minor
      Found in di.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function FooComplex has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      export function FooComplex(a, $foo, $barComplex, b, c) { this.args = arguments; }
      Severity: Minor
      Found in old-test/di-fixtures-basic.js - About 35 mins to fix
        Severity
        Category
        Status
        Source
        Language