schneidmaster/debatevid.io

View on GitHub
app/services/video_information_service.rb

Summary

Maintainability
A
2 hrs
Test Coverage
A
100%

Method youtube_link_info has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def youtube_link_info(link)
      uri = URI.parse(link)
      return invalid_json unless VALID_YOUTUBE_HOSTS.include?(uri.host)

      id =
Severity: Minor
Found in app/services/video_information_service.rb - About 1 hr to fix

    Method youtube_link_info has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def youtube_link_info(link)
          uri = URI.parse(link)
          return invalid_json unless VALID_YOUTUBE_HOSTS.include?(uri.host)
    
          id =
    Severity: Minor
    Found in app/services/video_information_service.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method link_info has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def link_info(link)
          is_vimeo = link.include?('vimeo')
          is_youtube = link.include?('youtube') || link.include?('youtu.be')
          return invalid_json unless is_vimeo || is_youtube
    
    
    Severity: Minor
    Found in app/services/video_information_service.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status