Showing 4 of 4 total issues
Method linux_variant has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
def linux_variant(exists_block, read_block)
variant = { :distro => nil, :family => nil }
if exists_block.('/etc/lsb-release')
lsb_release = read_block.('/etc/lsb-release') - Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method run has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def run
raise Niman::ConfigError, self.errors unless self.valid?
@instructions.each do |instruction|
yield(instruction) if block_given?
if is_file(instruction)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method exec has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def exec(command, use_sudo=false)
@machine.ui.info(command, {color: :green})
opts = { error_check: false, elevated: use_sudo }
handler = Proc.new do |type, data|
if [:stderr, :stdout].include?(type)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method install_package has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def install_package(package)
return unless package.installable?
shell = package_manager.shell
if package.respond_to?(:package_names)
package_name = package.package_names.fetch(shell.os.to_sym) { raise Niman::InstallError, "Package has no support for #{shell.os}" }- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"