Sign upLogin

scitran/core

View on GitHub
Star
api/auth/listauth.py

Summary

Maintainability
F
3 days
Test Coverage

Function files_sublist has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

def files_sublist(handler, container):
    """
    Files have slightly modified permissions centered around origin.
    Admin is required to remove files with an origin type other than engine or user.
    """
Severity: Minor
Found in api/auth/listauth.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function default_sublist has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

def default_sublist(handler, container):
    """
    This is the default permissions checker generator.
    The resulting permissions checker modifies the exec_op method by checking the user permissions
    on the container before actually executing this method.
Severity: Minor
Found in api/auth/listauth.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function notes_sublist has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def notes_sublist(handler, container):
    """
    permissions checker for notes_sublist
    """
    access = _get_access(handler.uid, container)
Severity: Minor
Found in api/auth/listauth.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function f has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def f(method, _id, query_params=None, payload=None, fileinfo=None, exclude_params=None):
Severity: Minor
Found in api/auth/listauth.py - About 45 mins to fix

    Consider simplifying this complex logical expression.
    Open

                if access >= INTEGER_PERMISSIONS['admin']:
                pass
            elif method == 'POST' and access >= INTEGER_PERMISSIONS['rw'] and payload['user'] == handler.uid:
                pass
            elif method == 'GET' and (access >= INTEGER_PERMISSIONS['ro'] or container.get('public')):
    Severity: Major
    Found in api/auth/listauth.py - About 40 mins to fix

      Function f has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              def f(method, _id, query_params = None, payload = None, exclude_params=None):
      Severity: Minor
      Found in api/auth/listauth.py - About 35 mins to fix

        Function f has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                def f(method, _id, query_params = None, payload = None, exclude_params=None):
        Severity: Minor
        Found in api/auth/listauth.py - About 35 mins to fix

          Function f has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  def f(method, _id, query_params=None, payload=None, exclude_params=None):
          Severity: Minor
          Found in api/auth/listauth.py - About 35 mins to fix

            Function f has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    def f(method, _id, query_params = None, payload = None, exclude_params=None):
            Severity: Minor
            Found in api/auth/listauth.py - About 35 mins to fix

              Function f has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      def f(method, _id, query_params = None, payload = None, exclude_params=None):
              Severity: Minor
              Found in api/auth/listauth.py - About 35 mins to fix

                Function f has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        def f(method, _id, query_params = None, payload = None, exclude_params=None):
                Severity: Minor
                Found in api/auth/listauth.py - About 35 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  def group_permissions_sublist(handler, container):
    """
    This is the customized permissions checker for group permissions operations.
    """
    access = _get_access(handler.uid, container)
                  Severity: Major
                  Found in api/auth/listauth.py and 1 other location - About 1 day to fix
                  api/auth/listauth.py on lines 108..122

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 136.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  def permissions_sublist(handler, container):
    """
    the customized permissions checker for permissions operations.
    """
    access = _get_access(handler.uid, container)
                  Severity: Major
                  Found in api/auth/listauth.py and 1 other location - About 1 day to fix
                  api/auth/listauth.py on lines 76..90

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 136.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status