Sign upLogin

scitran/core

View on GitHub
Star
api/auth/userauth.py

Summary

Maintainability
B
5 hrs
Test Coverage

Function default has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

def default(handler, user=None):
    def g(exec_op):
        def f(method, _id=None, query=None, payload=None, projection=None):
            if handler.public_request:
                handler.abort(403, 'public request is not authorized')
Severity: Minor
Found in api/auth/userauth.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

            if handler.public_request:
                handler.abort(403, 'public request is not authorized')
            elif handler.superuser_request and not (method == 'DELETE' and _id == handler.uid):
                pass
            elif handler.user_is_admin and (method == 'DELETE' and not _id == handler.uid):
Severity: Critical
Found in api/auth/userauth.py - About 2 hrs to fix

    Function f has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def f(method, _id=None, query=None, payload=None, projection=None):
    Severity: Minor
    Found in api/auth/userauth.py - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status