Sign upLogin

scitran/core

View on GitHub
Star
api/handlers/resolvehandler.py

Summary

Maintainability
C
7 hrs
Test Coverage

Function resolve has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

    def resolve(self):
        """Resolve a path through the hierarchy."""

        if self.public_request:
            self.abort(403, 'Request requires login')
Severity: Minor
Found in api/handlers/resolvehandler.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if y.get('_id') == self.uid:
                            ok = True
                            break
Severity: Major
Found in api/handlers/resolvehandler.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if y.get('_id') == self.uid:
                            ok = True
                            break
                else:
    Severity: Major
    Found in api/handlers/resolvehandler.py - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status