Sign upLogin

scitran/core

View on GitHub
Star
bin/dicom_doctype.py

Summary

Maintainability
D
2 days
Test Coverage

File dicom_doctype.py has 378 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python

import ast
import copy
import dateutil.parser
Severity: Minor
Found in bin/dicom_doctype.py - About 5 hrs to fix

    Function cast_array_from_string has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    def cast_array_from_string(string):
    array = None
    try:
        array = ast.literal_eval(string)
    except:
    Severity: Minor
    Found in bin/dicom_doctype.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function create_mappings has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    def create_mappings():
    public_dict = dicom._dicom_dict.DicomDictionary
    field_mappings = {}
    for k,v in public_dict.iteritems():
        vr_type = v[0]
    Severity: Minor
    Found in bin/dicom_doctype.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                    for an in analyses:
                    files = an.pop('files', [])
                    doc = {
                        'analysis':             an,
                        'session':              s,
    Severity: Major
    Found in bin/dicom_doctype.py - About 45 mins to fix

      Function handle_files has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def handle_files(parent, parent_type, files, dicom_mappings, permissions, doc):
      Severity: Minor
      Found in bin/dicom_doctype.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                        for a in acquisitions:
                    a.pop('info', None)
                    files = a.pop('files', [])
                    remove_blacklisted_keys(a)
        Severity: Major
        Found in bin/dicom_doctype.py - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if len(dcm_datetime) > 15:
        fraction_str = dcm_datetime[15:]
        fraction = float(dcm_datetime[15:])/10^(len(fraction_str))
        fraction = int(fraction*1000)
    else:
          Severity: Major
          Found in bin/dicom_doctype.py and 1 other location - About 4 hrs to fix
          bin/dicom_doctype.py on lines 217..222

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 77.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if len(dcm_time) > 7:
        fraction_str = dcm_time[7:]
        fraction = float(dcm_time[7:])/10^(len(fraction_str))
        fraction = int(fraction*1000)
    else:
          Severity: Major
          Found in bin/dicom_doctype.py and 1 other location - About 4 hrs to fix
          bin/dicom_doctype.py on lines 242..247

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 77.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status