Sign upLogin

scivision/glowaurora

View on GitHub
Star
glowaurora/plots.py

Summary

Maintainability
B
5 hrs
Test Coverage

Function plotprodloss has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

def plotprodloss(prod, loss, params, st):
    """ plot production/loss vs. alttiude """

    fg = figure(figsize=(15, 8))
    ax = fg.subplots(1, 2, sharey=True)
Severity: Minor
Found in glowaurora/plots.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _plotver has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def _plotver(sim, params, supertitle):
    if 'phitop' not in sim:
        return

    fg = figure(figsize=(15, 8))
Severity: Minor
Found in glowaurora/plots.py - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                        for s in r.T:
                        a.plot(s, s.z_km, label=s.reaction.item())
    Severity: Major
    Found in glowaurora/plots.py - About 45 mins to fix

      Function plotaurora has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      def plotaurora(params: dict, sim: xarray.Dataset):
    """ Plot all sorts of auroral/dayglow parameters from GLOW simulation. """
    makeplot = params['makeplot']
    if not makeplot:
        return
      Severity: Minor
      Found in glowaurora/plots.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status