Sign upLogin

scivision/transcarread

View on GitHub
Star

Showing 7 of 7 total issues

File __init__.py has 441 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import logging
from pathlib import Path
from datetime import datetime, timedelta
import numpy as np
from scipy.interpolate import interp1d
Severity: Minor
Found in transcarread/__init__.py - About 6 hrs to fix

    Function plot_isr has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    def plot_isr(iono: xarray.Dataset, infile: Path, tctime: dict, plot_params: list, verbose: bool = False):
    """Plot Transcar ISR parameters"""
    time = iono.time.values.astype("datetime64[us]")

    alt = iono.alt_km.values
    Severity: Minor
    Found in transcarread/plots.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function interpdat has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    def interpdat(md: xarray.DataArray, dz, raw: np.ndarray, newaltmethod: str = None) -> tuple:
    """interpolate data to new altitude grid"""
    # %% was interpolation requested?
    if dz is None or newaltmethod is None:
        return md, raw
    Severity: Minor
    Found in transcarread/__init__.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _tplot has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def _tplot(t, tctime: dict, fg, ax, pcm, ttxt: str, infile: Path):
    Severity: Major
    Found in transcarread/plots.py - About 50 mins to fix

      Function _plot1d has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def _plot1d(y: np.ndarray, z: np.ndarray, name: str, infile: Path, tctime: dict, time):
      Severity: Minor
      Found in transcarread/plots.py - About 45 mins to fix

        Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(
        Severity: Minor
        Found in transcarread/__init__.py - About 35 mins to fix

          Function plot_isr has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def plot_isr(iono: xarray.Dataset, infile: Path, tctime: dict, plot_params: list, verbose: bool = False):
          Severity: Minor
          Found in transcarread/plots.py - About 35 mins to fix
            Severity
            Category
            Status
            Source
            Language