Sign upLogin

scott-wyatt/countrystatesjs

View on GitHub
Star

Showing 5 of 5 total issues

Function Country has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var Country = function () {
  var _returnCountry = function (country, type) {
    var key
    if (type === 'name') {
      key = findIndex[normalizeName(country)]
Severity: Major
Found in lib/statejs.js - About 2 hrs to fix

    Function _returnCountry has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      var _returnCountry = function (country, type) {
    var key
    if (type === 'name') {
      key = findIndex[normalizeName(country)]
      return _countryList[key]
    Severity: Minor
    Found in lib/statejs.js - About 1 hr to fix

      Function Country has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      var Country = function () {
  var _returnCountry = function (country, type) {
    var key
    if (type === 'name') {
      key = findIndex[normalizeName(country)]
      Severity: Minor
      Found in lib/statejs.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

            return _.find(_countryList, function (thiscountry) {
        return thiscountry.ISO.alpha2 === country
      })
      Severity: Major
      Found in lib/statejs.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return _statesList[stateKey]
        Severity: Major
        Found in lib/statejs.js - About 30 mins to fix
          Severity
          Category
          Status
          Source
          Language