Sign upLogin

scottohara/loot

View on GitHub
Star
app/models/account.rb

Summary

Maintainability
B
6 hrs
Test Coverage
A
100%

Method list has 142 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def list
            # Get the current holding balance of all investment accounts
            investment_accounts = ::ActiveRecord::Base.connection.execute <<-QUERY
                SELECT                    accounts.id,
                                                accounts.name,
Severity: Major
Found in app/models/account.rb - About 5 hrs to fix

    Method update_from_json has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def update_from_json(json)
        original_account_type = account_type

        self.name = json['name']
        self.account_type = json['account_type']
    Severity: Minor
    Found in app/models/account.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status