Sign upLogin

scottohara/loot

View on GitHub
Star
app/models/concerns/transactable.rb

Summary

Maintainability
C
1 day
Test Coverage
A
100%

Method closing_balance has 84 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def closing_balance(balance_opts = {})
        as_at =
            begin
                ::Date.parse(balance_opts[:as_at]).to_s
            rescue ::TypeError, ::ArgumentError
Severity: Major
Found in app/models/concerns/transactable.rb - About 3 hrs to fix

    Method ledger_query has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def ledger_query(opts)
        # Get the specified number of transactions up to the given date
        transactions
            .for_ledger(opts)
            .select(
    Severity: Major
    Found in app/models/concerns/transactable.rb - About 2 hrs to fix

      Method closing_balance has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          def closing_balance(balance_opts = {})
        as_at =
            begin
                ::Date.parse(balance_opts[:as_at]).to_s
            rescue ::TypeError, ::ArgumentError
      Severity: Minor
      Found in app/models/concerns/transactable.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method to_ledger_json has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def to_ledger_json(trx)
        {
            id: trx['id'],
            transaction_type: trx['transaction_type'],
            transaction_date: trx['transaction_date'],
      Severity: Minor
      Found in app/models/concerns/transactable.rb - About 1 hr to fix

        Method to_ledger_json has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            def to_ledger_json(trx)
        {
            id: trx['id'],
            transaction_type: trx['transaction_type'],
            transaction_date: trx['transaction_date'],
        Severity: Minor
        Found in app/models/concerns/transactable.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status