Sign upLogin

scottohara/loot

View on GitHub
Star
src/categories/controllers/index.ts

Summary

Maintainability
C
1 day
Test Coverage
A
100%

Function editCategory has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public editCategory(index?: number): void {
        // Helper function to sort by direction, then by category name, then by subcategory name
        function byDirectionAndName(a: Category, b: Category): number {
            let x: string, y: string;
Severity: Major
Found in src/categories/controllers/index.ts - About 2 hrs to fix

    Function deleteCategory has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public deleteCategory(index: number): void {
        // Check if the category can be deleted
        this.categoryModel
            .find(Number(this.categories[index].id))
            .then((category: Category): void => {
    Severity: Major
    Found in src/categories/controllers/index.ts - About 2 hrs to fix

      Function constructor has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public constructor(
        $scope: angular.IScope,
        $transitions: angular.ui.IStateParamsService,
        private readonly $uibModal: angular.ui.bootstrap.IModalService,
        private readonly $timeout: angular.ITimeoutService,
      Severity: Minor
      Found in src/categories/controllers/index.ts - About 1 hr to fix

        Function editCategory has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            public editCategory(index?: number): void {
        // Helper function to sort by direction, then by category name, then by subcategory name
        function byDirectionAndName(a: Category, b: Category): number {
            let x: string, y: string;
        Severity: Minor
        Found in src/categories/controllers/index.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status