Sign upLogin

scottohara/loot

View on GitHub
Star
src/og-components/og-input-calculator/directives/og-input-calculator.ts

Summary

Maintainability
D
2 days
Test Coverage
A
100%

Function constructor has 174 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public constructor(
        $window: angular.IWindowService,
        $timeout: angular.ITimeoutService,
        ogModalErrorService: OgModalErrorService,
    ) {
Severity: Major
Found in src/og-components/og-input-calculator/directives/og-input-calculator.ts - About 6 hrs to fix

    Function link has 158 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                    link(
                    scope: OgInputCalculatorScope,
                    iElement: JQuery<Element>,
                    iAttrs: angular.IAttributes,
                    controllers: angular.IController[],
    Severity: Major
    Found in src/og-components/og-input-calculator/directives/og-input-calculator.ts - About 6 hrs to fix

      Function constructor has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
      Open

          public constructor(
        $window: angular.IWindowService,
        $timeout: angular.ITimeoutService,
        ogModalErrorService: OgModalErrorService,
    ) {
      Severity: Minor
      Found in src/og-components/og-input-calculator/directives/og-input-calculator.ts - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function calculate has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                          scope.calculate = (value: string): void => {
                        // Default the result to the current view value
                        scope.result = Number(scope.ogInput.formattedToRaw(value));

                        // Make the current view value available on the scope
      Severity: Minor
      Found in src/og-components/og-input-calculator/directives/og-input-calculator.ts - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status