Sign upLogin

scottohara/loot

View on GitHub
Star
src/schedules/controllers/index.ts

Summary

Maintainability
B
5 hrs
Test Coverage
A
100%

Function editSchedule has 74 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private editSchedule(index?: number): void {
        // Helper function to sort by next due date, then by transaction id
        function byNextDueDateAndId(
            a: ScheduledTransaction,
            b: ScheduledTransaction,
Severity: Major
Found in src/schedules/controllers/index.ts - About 2 hrs to fix

    Function editSchedule has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        private editSchedule(index?: number): void {
        // Helper function to sort by next due date, then by transaction id
        function byNextDueDateAndId(
            a: ScheduledTransaction,
            b: ScheduledTransaction,
    Severity: Minor
    Found in src/schedules/controllers/index.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function constructor has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public constructor(
        $scope: angular.IScope,
        $transitions: angular.ui.IStateParamsService,
        private readonly $uibModal: angular.ui.bootstrap.IModalService,
        private readonly $timeout: angular.ITimeoutService,
    Severity: Minor
    Found in src/schedules/controllers/index.ts - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status