Sign upLogin

scottohara/loot

View on GitHub
Star
src/securities/controllers/index.ts

Summary

Maintainability
B
5 hrs
Test Coverage
A
100%

Function deleteSecurity has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public deleteSecurity(index: number): void {
        // Check if the security can be deleted
        this.securityModel
            .find(Number(this.securities[index].id))
            .then((security: Security): void => {
Severity: Minor
Found in src/securities/controllers/index.ts - About 1 hr to fix

    Function editSecurity has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public editSecurity(index?: number): void {
        // Helper function to sort by security current holding and name
        function byHoldingAndName(a: Security, b: Security): number {
            let x: boolean, y: boolean;
    Severity: Minor
    Found in src/securities/controllers/index.ts - About 1 hr to fix

      Function constructor has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public constructor(
        $scope: angular.IScope,
        $transitions: angular.ui.IStateParamsService,
        private readonly $uibModal: angular.ui.bootstrap.IModalService,
        private readonly $timeout: angular.ITimeoutService,
      Severity: Minor
      Found in src/securities/controllers/index.ts - About 1 hr to fix

        Function editSecurity has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public editSecurity(index?: number): void {
        // Helper function to sort by security current holding and name
        function byHoldingAndName(a: Security, b: Security): number {
            let x: boolean, y: boolean;
        Severity: Minor
        Found in src/securities/controllers/index.ts - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status