Sign upLogin

scottohara/loot

View on GitHub
Star
src/transactions/directives/status.ts

Summary

Maintainability
B
5 hrs
Test Coverage
A
100%

Function constructor has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public constructor(
        $sce: angular.ISCEService,
        transactionModel: TransactionModel,
        accountModel: AccountModel,
        ogModalErrorService: OgModalErrorService,
Severity: Major
Found in src/transactions/directives/status.ts - About 2 hrs to fix

    Function link has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                    link(scope: TransactionStatusScope, iElement: JQuery<Element>): void {
                    // Set the current status & icon, calculate the next status
                    function setCurrentStatus(status: TransactionStatus): void {
                        scope.currentStatus =
                            null === status || "" === status ? "Unreconciled" : status;
    Severity: Minor
    Found in src/transactions/directives/status.ts - About 1 hr to fix

      Function constructor has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public constructor(
        $sce: angular.ISCEService,
        transactionModel: TransactionModel,
        accountModel: AccountModel,
        ogModalErrorService: OgModalErrorService,
      Severity: Minor
      Found in src/transactions/directives/status.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status