scottwernervt/cloudstorage

View on GitHub
src/cloudstorage/drivers/amazon.py

Summary

Maintainability
D
2 days
Test Coverage

File amazon.py has 491 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""Amazon Simple Storage Service (S3) Driver."""
import logging
from typing import Any, Dict, Iterable, List, TYPE_CHECKING  # noqa: F401
from urllib.parse import quote, urljoin

Severity: Minor
Found in src/cloudstorage/drivers/amazon.py - About 7 hrs to fix

    S3Driver has 28 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class S3Driver(Driver):
        """Driver for interacting with Amazon Simple Storage Service (S3).
    
        .. code-block:: python
    
    
    Severity: Minor
    Found in src/cloudstorage/drivers/amazon.py - About 3 hrs to fix

      Function upload_blob has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          def upload_blob(
              self,
              container: Container,
              filename: FileLike,
              blob_name: str = None,
      Severity: Minor
      Found in src/cloudstorage/drivers/amazon.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function upload_blob has 10 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def upload_blob(
      Severity: Major
      Found in src/cloudstorage/drivers/amazon.py - About 1 hr to fix

        Function generate_container_upload_url has 10 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def generate_container_upload_url(
        Severity: Major
        Found in src/cloudstorage/drivers/amazon.py - About 1 hr to fix

          Function generate_container_upload_url has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              def generate_container_upload_url(
                  self,
                  container: Container,
                  blob_name: str,
                  expires: int = 3600,
          Severity: Minor
          Found in src/cloudstorage/drivers/amazon.py - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _get_bucket has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def _get_bucket(self, bucket_name: str, validate: bool = True):
                  """Get a S3 bucket.
          
                  :param bucket_name: The Bucket's name identifier.
                  :type bucket_name: str
          Severity: Minor
          Found in src/cloudstorage/drivers/amazon.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function generate_blob_download_url has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def generate_blob_download_url(
          Severity: Minor
          Found in src/cloudstorage/drivers/amazon.py - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status