scottwernervt/cloudstorage

View on GitHub
src/cloudstorage/drivers/local.py

Summary

Maintainability
D
2 days
Test Coverage

File local.py has 577 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""Local File System Driver."""
import errno
import hashlib
import json
import logging
Severity: Major
Found in src/cloudstorage/drivers/local.py - About 1 day to fix

    LocalDriver has 33 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class LocalDriver(Driver):
        """Driver for interacting with local file-system.
    
        .. code-block:: python
    
    
    Severity: Minor
    Found in src/cloudstorage/drivers/local.py - About 4 hrs to fix

      Function _make_blob has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          def _make_blob(self, container: Container, object_name: str) -> Blob:
              """Convert local file name to a Cloud Storage Blob.
      
              :param container: Container instance.
              :type container: :class:`.Container`
      Severity: Minor
      Found in src/cloudstorage/drivers/local.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _set_file_attributes has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          def _set_file_attributes(self, filename: str, attributes: Dict) -> None:
              """Set extended filesystem attributes to a file.
      
              Metadata is set to `user.metadata.<attr-name>` and remaining attributes
              are set to `user.<attr-name>`.
      Severity: Minor
      Found in src/cloudstorage/drivers/local.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function get_blobs has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          def get_blobs(self, container: Container) -> Iterable[Blob]:
              container_path = self._get_folder_path(container, validate=True)
      
              for folder, sub_folders, files in os.walk(container_path, topdown=True):
                  # Remove unwanted sub-folders
      Severity: Minor
      Found in src/cloudstorage/drivers/local.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function generate_container_upload_url has 10 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def generate_container_upload_url(
      Severity: Major
      Found in src/cloudstorage/drivers/local.py - About 1 hr to fix

        Function upload_blob has 10 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def upload_blob(
        Severity: Major
        Found in src/cloudstorage/drivers/local.py - About 1 hr to fix

          Function download_blob has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              def download_blob(self, blob: Blob, destination: FileLike) -> None:
                  blob_path = self._get_file_path(blob)
          
                  if isinstance(destination, str):
                      base_name = os.path.basename(destination)
          Severity: Minor
          Found in src/cloudstorage/drivers/local.py - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function upload_blob has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              def upload_blob(
                  self,
                  container: Container,
                  filename: FileLike,
                  blob_name: str = None,
          Severity: Minor
          Found in src/cloudstorage/drivers/local.py - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function generate_blob_download_url has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def generate_blob_download_url(
          Severity: Minor
          Found in src/cloudstorage/drivers/local.py - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status