Sign upLogin

scottwillson/racing_on_rails

View on GitHub
Star
app/controllers/authorization.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Consider simplifying this complex logical expression.
Open

    unless administrator? ||
           (@event && (current_person == @event.promoter || @event.editors.include?(current_person))) ||
           (@race && (current_person == @race.event.promoter || @race.event.editors.include?(current_person)))

      redirect_to unauthorized_path
Severity: Major
Found in app/controllers/authorization.rb - About 1 hr to fix

    Method require_administrator_or_promoter has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def require_administrator_or_promoter
    return false unless require_current_person

    unless administrator? ||
           (@event && (current_person == @event.promoter || @event.editors.include?(current_person))) ||
    Severity: Minor
    Found in app/controllers/authorization.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method require_same_person_or_administrator_or_editor has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def require_same_person_or_administrator_or_editor
    return false unless require_current_person

    unless administrator? || (@person && current_person == @person) || @person&.editors&.include?(current_person)
      redirect_to unauthorized_path
    Severity: Minor
    Found in app/controllers/authorization.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method require_same_person_or_administrator has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def require_same_person_or_administrator
    return false unless require_current_person

    unless administrator? || (@person && current_person == @person)
      redirect_to unauthorized_path
    Severity: Minor
    Found in app/controllers/authorization.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status