Sign upLogin

scottwillson/racing_on_rails

View on GitHub
Star
app/controllers/competitions/bar_controller.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method show has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def show
      discipline = Discipline[params["discipline"]]
      if discipline.nil?
        flash.now[:warn] = "Could not find discipline \'#{params['discipline']}\'"
        return render(:show)
Severity: Minor
Found in app/controllers/competitions/bar_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method show has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def show
      discipline = Discipline[params["discipline"]]
      if discipline.nil?
        flash.now[:warn] = "Could not find discipline \'#{params['discipline']}\'"
        return render(:show)
Severity: Minor
Found in app/controllers/competitions/bar_controller.rb - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

            return render(:show)
    Severity: Major
    Found in app/controllers/competitions/bar_controller.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return redirect_to(category: category.friendly_param, only_path: true) if category.friendly_param != params["category"]
      Severity: Major
      Found in app/controllers/competitions/bar_controller.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return redirect_to("http://#{RacingAssociation.current.static_host}/bar/#{@year}")
        Severity: Major
        Found in app/controllers/competitions/bar_controller.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return redirect_to("http://#{RacingAssociation.current.static_host}/bar/#{@year}/overall_by_age.html")
          Severity: Major
          Found in app/controllers/competitions/bar_controller.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return render(:show)
            Severity: Major
            Found in app/controllers/competitions/bar_controller.rb - About 30 mins to fix

              FIXME found
              Open

              # FIXME Add test for overall and make logic cleaner
              Severity: Minor
              Found in app/controllers/competitions/bar_controller.rb by fixme

              There are no issues that match your filters.

              Category
              Status